Re: [greenstone-users] highlighting messes up macros [REALLYSOLVED(?)]

From Michael Dewsnip
DateThu, 20 Oct 2005 12:12:03 +1300
Subject Re: [greenstone-users] highlighting messes up macros [REALLYSOLVED(?)]
In-Reply-To (4343C7E7-70101-gmx-net)
Dear Jens,

Thank you for this fix. I tried to think of cases where expanding before
highlighting could cause problems and couldn't, so I've committed it to
CVS. It should get a bit of testing before the next (unstable) release
at the beginning of next year, in any case.

Thanks for another contribution to Greenstone!

All the best,

Michael

jens wille wrote:

>hi katherine!
>
>i now modified highlightext.cpp to expand macros before highlighting
>(instead of skipping macro names/arguments) which seems to solve the
>described problem completely - yet still the question: might this
>expanding-before-highlighting cause any trouble?
>
>anyway, here's what i did (in the highlighttext function):
>
>// expand macros _before_ highlighting
>text_t exptext = "";
>disp.expandstring(text, exptext);
>
>+ substituted the two following occurences of 'text' with 'exptext'
>
>(hope this is proper c++ ;-)
>
>if there aren't any objections against doing this i consider it the
>final solution :-)
>
>cheers
>jens
>
>_______________________________________________
>greenstone-users mailing list
>greenstone-users@list.scms.waikato.ac.nz
>https://list.scms.waikato.ac.nz/mailman/listinfo/greenstone-users
>
>
>
>