Re: [greenstone-devel] accumulated metadata in HTMLPlug

From jens wille
DateFri, 17 Dec 2004 18:34:02 +0100
Subject Re: [greenstone-devel] accumulated metadata in HTMLPlug
In-Reply-To (41C23716-4050808-cs-waikato-ac-nz)
Katherine Don wrote:
> After emailing you, I realised that I had already fixed this bug
> - by always using add_utf8_metadata instead of set_utf8_metadata.
> Do you think that there are times when you *do* want the metadata
> to overwrite?
well, maybe i should have had a look at the cvs tree before ;-)

btw, there's a slight mishap occured: the matching pattern says
/^Metadata name=$quot(.*?)$quot(?: mode=$quot(.*?)$quot)/s
but here's a ? missing after the closing parenthesis ----^ !
i just forgot it when i took my modifications to the 2.52 HTMLPlug.

however, i don't think that it's a problem for /me/ to allways have
metadata _added_ - be it that i just change HTMLPlug again if needed
- but i think, generally, it would be better to have the opportunity
to chose the mode, just like in metadata.xml, instead of being
limited to one.

best regards

jens